Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to forbiddenapis 2.5 #29285

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Update to forbiddenapis 2.5 #29285

merged 1 commit into from
Mar 29, 2018

Conversation

uschindler
Copy link
Contributor

This pull request updates forbiddenapis to version 2.5.

The new release supports Java 10 bytecode and also adds support for checking violations in commons-io-2.6.

While testing this I figured out one issue: You may pass -Drepos.mavenLocal=true to gradle, but this does not work globally. It will still complain about missing forbiddenapis (before it was on Maven Central). I was not able to fix this, because I have no idea what the if project==rootProject check should do. @rjernst ?

To support me in developing the Gradle Plugin of forbiddenapis, please add support for the above property. I also figured out that there are 2 sysprops: repos.mavenLocal and repos.mavenlocal, neither work: https://github.com/elastic/elasticsearch/search?utf8=%E2%9C%93&q=repos.mavenLocal

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@nik9000 nik9000 added :Delivery/Build Build or test infrastructure v7.0.0 v6.3.0 review and removed v6.3.0 labels Mar 28, 2018
@rjernst
Copy link
Member

rjernst commented Mar 29, 2018

@elasticmachine test this please

@rjernst
Copy link
Member

rjernst commented Mar 29, 2018

Thanks for this PR @uschindler.

there are 2 sysprops: repos.mavenLocal and repos.mavenlocal

This is a bug, I will fix.

I have no idea what the if project==rootProject check should do

This set of code under buildSrc is for "bootstrapping". We configure a (sort of) fake project called build-tools which points at the buildSrc directory. This allows us to not have to duplicate a lot of publication code for the code in buildSrc. Essentially, buildSrc/build.gradle is run twice. The first time, it is part of grade's bootstrapping, where it builds buildSrc. The second time, it is as the :build-tools project. Unfortunately the maven repos code must be in both places (specifically so mavenLocal can work in this case). I think fixing the casing should fix the problem you had.

@rjernst
Copy link
Member

rjernst commented Mar 29, 2018

I opened #29289.

@rjernst rjernst merged commit 6578d8a into elastic:master Mar 29, 2018
@rjernst
Copy link
Member

rjernst commented Mar 29, 2018

Thanks @uschindler

rjernst pushed a commit that referenced this pull request Mar 29, 2018
@uschindler @rjernst
Update to forbiddenapis 2.5 (#29285)
6b25b71
@uschindler uschindler deleted the features/forbiddenapis-2.5 branch March 29, 2018 06:38
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.3.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uschindler @elasticmachine @rjernst @nik9000 @colings86 @mark-vieira